[RFC] Use nested checkboxes and radio buttons all over admin #2429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are not used anywhere
The bootstrap label style has better readability
For radios and checkboxes nested in label tags we want to add some small right margin to enhance readability
We want the checkboxes to be vertically aligned to the text fields.
Checkboxes should be nested in label tags, so we can style them better
Most of our radio buttons are already nested in label tags. This converts the last two left overs.
tvdeyen
added
changelog:solidus_backend
kennyadsl
approved these changes
Dec 4, 2017
There was a problem hiding this comment.
I don't have a strong opinion on font size increase, but I'm 👍 if you think it's ok.
If someone else has my same doubts about removing for attribute from labels, it's perfectly valid and right. Label without for will be associated to all its contents. 👍
Thanks!
jhawthorn
approved these changes
Dec 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following our own styleguide and due to better styleability we
should nest checkboxes and radio buttons into their labels.
This also removes some redundant and unused style definitions
regarding labels, checkboxes and radio buttons.
The most debatable change might be the label font-size change (from 90% to 100%)
Before
After